netdev - Re: [PATCHv2 next] net: add option to not create fall-back tunnels in root-ns as well

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9fce7d7e-aa33-a451-ab4a-a297b1317310@infradead.org>
Date:   Tue, 25 Aug 2020 15:47:25 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Mahesh Bandewar <maheshb@...gle.com>,
        Netdev <netdev@...r.kernel.org>
Cc:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Mahesh Bandewar <mahesh@...dewar.net>,
        Maciej Zenczykowski <maze@...gle.com>,
        Jian Yang <jianyang@...gle.com>
Subject: Re: [PATCHv2 next] net: add option to not create fall-back tunnels in
 root-ns as well

On 8/25/20 3:42 PM, Mahesh Bandewar wrote:
> The sysctl that was added  earlier by commit 79134e6ce2c ("net: do
> not create fallback tunnels for non-default namespaces") to create
> fall-back only in root-ns. This patch enhances that behavior to provide
> option not to create fallback tunnels in root-ns as well. Since modules
> that create fallback tunnels could be built-in and setting the sysctl
> value after booting is pointless, so added a kernel cmdline options to
> change this default. The default setting is preseved for backward
> compatibility. The kernel command line option of fb_tunnels=initns will
> set the sysctl value to 1 and will create fallback tunnels only in initns
> while kernel cmdline fb_tunnels=none will set the sysctl value to 2 and
> fallback tunnels are skipped in every netns.
> 
> Signed-off-by: Mahesh Bandewar <maheshb@...gle.com>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Maciej Zenczykowski <maze@...gle.com>
> Cc: Jian Yang <jianyang@...gle.com>
> ---
> v1->v2
>   Removed the Kconfig option which would force rebuild and replaced with
>   kcmd-line option
> 
>  .../admin-guide/kernel-parameters.txt         |  5 +++++
>  Documentation/admin-guide/sysctl/net.rst      | 20 +++++++++++++------
>  include/linux/netdevice.h                     |  7 ++++++-
>  net/core/sysctl_net_core.c                    | 17 ++++++++++++++--
>  4 files changed, 40 insertions(+), 9 deletions(-)
> 
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index a1068742a6df..09a51598c792 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -801,6 +801,11 @@
>  
>  	debug_objects	[KNL] Enable object debugging
>  
> +	fb_tunnels=	[NET]
> +			Format: { initns | none }
> +			See Documentation/admin-guide/sysctl/net.rst for
> +			fb_tunnels_only_for_init_ns
> +

Not at this location in this file.
Entries in this file are meant to be in alphabetical order (mostly).

So leave debug_objects and no_debug_objects together, and insert fb_tunnels
between fail_make_request= and floppy=.

Thanks.

>  	no_debug_objects
>  			[KNL] Disable object debugging
>  

-- 
~Randy