netdev - Re: [PATCH] net: atheros: switch from 'pci_' to 'dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200824.173355.1151795672938918588.davem@davemloft.net>
Date:   Mon, 24 Aug 2020 17:33:55 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     christophe.jaillet@...adoo.fr
Cc:     jcliburn@...il.com, chris.snook@...il.com, kuba@...nel.org,
        yanaijie@...wei.com, hkallweit1@...il.com, mhabets@...arflare.com,
        mst@...hat.com, leon@...nel.org, colin.king@...onical.com,
        yuehaibing@...wei.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] net: atheros: switch from 'pci_' to 'dma_' API

From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Date: Sun, 23 Aug 2020 10:03:53 +0200

> The wrappers in include/linux/pci-dma-compat.h should go away.
> 
> The patch has been generated with the coccinelle script below and has been
> hand modified to replace GFP_ with a correct flag.
> It has been compile tested.
> 
> When memory is allocated in 'atl1e_setup_ring_resources()' (atl1e_main.c),
> 'atl1_setup_ring_resources()' (atl1.c) and 'atl2_setup_ring_resources()'
> (atl2.c) GFP_KERNEL can be used because it can be called from a .ndo_open.
> 
> 'atl1_setup_ring_resources()' (atl1.c) can also be called from a
> '.set_ringparam' (see struct ethtool_ops) where sleep is also allowed.
> 
> Both cases are protected by 'rtnl_lock()' which is a mutex. So these
> function can sleep.
 ...
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Applied.