netdev - Re: [PATCH v2] net: dp83869: Fix RGMII internal delay configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a7f527da-f28c-7a8b-3b62-acc9663cb44c@ti.com>
Date:   Wed, 26 Aug 2020 06:35:45 -0500
From:   Dan Murphy <dmurphy@...com>
To:     Daniel Gorsulowski <daniel.gorsulowski@....eu>,
        <netdev@...r.kernel.org>
CC:     <davem@...emloft.net>, <andrew@...n.ch>, <f.fainelli@...il.com>,
        <hkallweit1@...il.com>
Subject: Re: [PATCH v2] net: dp83869: Fix RGMII internal delay configuration

Hello

On 8/26/20 12:00 AM, Daniel Gorsulowski wrote:
> The RGMII control register at 0x32 indicates the states for the bits
> RGMII_TX_CLK_DELAY and RGMII_RX_CLK_DELAY as follows:
>
>    RGMII Transmit/Receive Clock Delay
>      0x0 = RGMII transmit clock is shifted with respect to transmit/receive data.
>      0x1 = RGMII transmit clock is aligned with respect to transmit/receive data.
>
> This commit fixes the inversed behavior of these bits
>
> Fixes: 736b25afe284 ("net: dp83869: Add RGMII internal delay configuration")
> Signed-off-by: Daniel Gorsulowski <daniel.gorsulowski@....eu>
> ---
> v2: fixed indentation and commit style
>
>   drivers/net/phy/dp83869.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/phy/dp83869.c b/drivers/net/phy/dp83869.c
> index 58103152c601..6b98d74b5102 100644
> --- a/drivers/net/phy/dp83869.c
> +++ b/drivers/net/phy/dp83869.c
> @@ -427,18 +427,18 @@ static int dp83869_config_init(struct phy_device *phydev)
>   			return ret;
>   
>   		val = phy_read_mmd(phydev, DP83869_DEVADDR, DP83869_RGMIICTL);
> -		val &= ~(DP83869_RGMII_TX_CLK_DELAY_EN |
> -			 DP83869_RGMII_RX_CLK_DELAY_EN);
> +		val |= (DP83869_RGMII_TX_CLK_DELAY_EN |
> +			DP83869_RGMII_RX_CLK_DELAY_EN);
>   
>   		if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID)
> -			val |= (DP83869_RGMII_TX_CLK_DELAY_EN |
> -				DP83869_RGMII_RX_CLK_DELAY_EN);
> +			val &= ~(DP83869_RGMII_TX_CLK_DELAY_EN |
> +				 DP83869_RGMII_RX_CLK_DELAY_EN);
>   
>   		if (phydev->interface == PHY_INTERFACE_MODE_RGMII_TXID)
> -			val |= DP83869_RGMII_TX_CLK_DELAY_EN;
> +			val &= ~DP83869_RGMII_TX_CLK_DELAY_EN;
>   
>   		if (phydev->interface == PHY_INTERFACE_MODE_RGMII_RXID)
> -			val |= DP83869_RGMII_RX_CLK_DELAY_EN;
> +			val &= ~DP83869_RGMII_RX_CLK_DELAY_EN;
>   
>   		ret = phy_write_mmd(phydev, DP83869_DEVADDR, DP83869_RGMIICTL,
>   				    val);

With the exception on bot knowing what net tree this goes to via the subject

Acked-by: Dan Murphy <dmurphy@...com>