netdev - Re: ethernet-phy-ieee802.3-c22 binding and reset-gpios

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200826125658.GP2403519@lunn.ch>
Date:   Wed, 26 Aug 2020 14:56:58 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Sascha Hauer <s.hauer@...gutronix.de>
Cc:     netdev@...r.kernel.org, Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>, kernel@...gutronix.de
Subject: Re: ethernet-phy-ieee802.3-c22 binding and reset-gpios

On Wed, Aug 26, 2020 at 10:58:57AM +0200, Sascha Hauer wrote:
> Hi Andrew,
> 
> Well there is only one phy connected to the bus, so it makes no
> difference if I say the reset GPIO is for the whole bus or for a single
> phy only. The per bus reset should work, but currently it doesn't. First
> reason I found out that mdiobus_register() doesn't handle -EPROBE_DEFER
> returned by the devm_gpiod_get_optional() properly, patch follows.

Thanks

> Second reason is that the phy is not detected (id read returns 0xffff)
> when the reset is attached to the bus. So far I haven't found the reason
> for that.

Try giving the PHY a bit longer to recover from the reset before
probing it.

And what SoC are you using? Is it FEC ethernet driver? That has MDIO
issues at the moment.

     Andrew