netdev - Re: [PATCH bpf-next] selftests/bpf: Fix open call in trigger_fstat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQLc5=Y_ssfp53DuJvRRu4YdQ=qdKS9fsP23XhqLXeb-vQ@mail.gmail.com>
Date:   Wed, 26 Aug 2020 07:25:21 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Jiri Olsa <jolsa@...nel.org>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Network Development <netdev@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>, Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        Andrii Nakryiko <andriin@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...omium.org>,
        Jesper Dangaard Brouer <brouer@...hat.com>
Subject: Re: [PATCH bpf-next] selftests/bpf: Fix open call in trigger_fstat_events

On Wed, Aug 26, 2020 at 3:19 AM Jiri Olsa <jolsa@...nel.org> wrote:
>
> Alexei reported compile breakage on newer systems with
> following error:
>
>   In file included from /usr/include/fcntl.h:290:0,
>   4814                 from ./test_progs.h:29,
>   4815                 from
>   .../bpf-next/tools/testing/selftests/bpf/prog_tests/d_path.c:3:
>   4816In function ‘open’,
>   4817    inlined from ‘trigger_fstat_events’ at
>   .../bpf-next/tools/testing/selftests/bpf/prog_tests/d_path.c:50:10,
>   4818    inlined from ‘test_d_path’ at
>   .../bpf-next/tools/testing/selftests/bpf/prog_tests/d_path.c:119:6:
>   4819/usr/include/x86_64-linux-gnu/bits/fcntl2.h:50:4: error: call to
>   ‘__open_missing_mode’ declared with attribute error: open with O_CREAT
>   or O_TMPFILE in second argument needs 3 arguments
>   4820    __open_missing_mode ();
>   4821    ^~~~~~~~~~~~~~~~~~~~~~
>
> We're missing permission bits as 3rd argument
> for open call with O_CREAT flag specified.
>
> Reported-by: Alexei Starovoitov <ast@...nel.org>
> Fixes: e4d1af4b16f8 ("selftests/bpf: Add test for d_path helper")
> Signed-off-by: Jiri Olsa <jolsa@...nel.org>

Applied. Thanks