netdev - Re: [PATCH v1] net: phy: leds: Deduplicate link LED trigger registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200826152059.GS1891694@smile.fi.intel.com>
Date:   Wed, 26 Aug 2020 18:20:59 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     David Miller <davem@...emloft.net>
Cc:     andrew@...n.ch, f.fainelli@...il.com, hkallweit1@...il.com,
        netdev@...r.kernel.org, linux@...linux.org.uk
Subject: Re: [PATCH v1] net: phy: leds: Deduplicate link LED trigger
 registration

On Tue, Aug 25, 2020 at 07:40:15AM -0700, David Miller wrote:
> From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Date: Mon, 24 Aug 2020 20:09:04 +0300
> 
> > Refactor phy_led_trigger_register() and deduplicate its functionality
> > when registering LED trigger for link.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

My bad... Missed LED_CLASS and saw even something has been built in
drivers/net/ but apparently wasn't enough to get this one compiled.

v2 will fix that.
Thanks!

> This doesn't compile:
> 
>   CC [M]  drivers/net/phy/phy_led_triggers.o
> drivers/net/phy/phy_led_triggers.c: In function ‘phy_led_triggers_register’:
> drivers/net/phy/phy_led_triggers.c:102:38: error: passing argument 2 of ‘phy_led_trigger_register’ from incompatible pointer type [-Werror=incompatible-pointer-types]
>   102 |  err = phy_led_trigger_register(phy, &phy->led_link_trigger, 0, "link");
>       |                                      ^~~~~~~~~~~~~~~~~~~~~~
>       |                                      |
>       |                                      struct phy_led_trigger **
> drivers/net/phy/phy_led_triggers.c:68:33: note: expected ‘struct phy_led_trigger *’ but argument is of type ‘struct phy_led_trigger **’
>    68 |         struct phy_led_trigger *plt,
>       |         ~~~~~~~~~~~~~~~~~~~~~~~~^~~
> 

-- 
With Best Regards,
Andy Shevchenko