netdev - Re: [PATCH net-next v3 2/3] net: openvswitch: refactor flow free function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOrHB_D3+R0uCav_3vV_PGCdix8F3g_w39CwX6h2Z+bhEwYi9A@mail.gmail.com>
Date:   Wed, 26 Aug 2020 12:23:18 -0700
From:   Pravin Shelar <pravin.ovn@...il.com>
To:     Tonghao Zhang <xiangxia.m.yue@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Cong Wang <xiyou.wangcong@...il.com>,
        ovs dev <dev@...nvswitch.org>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v3 2/3] net: openvswitch: refactor flow free function

On Mon, Aug 24, 2020 at 10:08 PM <xiangxia.m.yue@...il.com> wrote:
>
> From: Tonghao Zhang <xiangxia.m.yue@...il.com>
>
> Decrease table->count and ufid_count unconditionally,
> because we only don't use count or ufid_count to count
> when flushing the flows. To simplify the codes, we
> remove the "count" argument of table_instance_flow_free.
>
> To avoid a bug when deleting flows in the future, add
> WARN_ON in flush flows function.
>
> Cc: Pravin B Shelar <pshelar@....org>
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@...il.com>
Looks good.

Acked-by: Pravin B Shelar <pshelar@....org>