netdev - Re: [PATCH bpf-next] libbpf: Fix unintentional success return code in bpf_object_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQJ11XYCRpx23Oq8WZ18KqCde786J1Zk_KuywyMx1hzQKg@mail.gmail.com>
Date:   Wed, 26 Aug 2020 15:17:40 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Alex Gartrell <alexgartrell@...il.com>
Cc:     Network Development <netdev@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH bpf-next] libbpf: Fix unintentional success return code in bpf_object__load

On Wed, Aug 26, 2020 at 12:56 AM Alex Gartrell <alexgartrell@...il.com> wrote:
>
> There are code paths where EINVAL is returned directly without setting
> errno. In that case, errno could be 0, which would mask the
> failure. For example, if a careless programmer set log_level to 10000
> out of laziness, they would have to spend a long time trying to figure
> out why.
>
> Fixes: 4f33ddb4e3e2 ("libbpf: Propagate EPERM to caller on program load")
> Signed-off-by: Alex Gartrell <alexgartrell@...il.com>

Applied. Thanks