netdev - Re: [PATCH net-next v1] taprio: Fix using wrong queues in gate mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200826.154812.1454781316271352545.davem@davemloft.net>
Date:   Wed, 26 Aug 2020 15:48:12 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     vinicius.gomes@...el.com
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        jiri@...nulli.us, vladimir.oltean@....com, kurt@...utronix.de
Subject: Re: [PATCH net-next v1] taprio: Fix using wrong queues in gate mask

From: Vinicius Costa Gomes <vinicius.gomes@...el.com>
Date: Tue, 25 Aug 2020 10:44:04 -0700

> Since commit 9c66d1564676 ("taprio: Add support for hardware
> offloading") there's a bit of inconsistency when offloading schedules
> to the hardware:
> 
> In software mode, the gate masks are specified in terms of traffic
> classes, so if say "sched-entry S 03 20000", it means that the traffic
> classes 0 and 1 are open for 20us; when taprio is offloaded to
> hardware, the gate masks are specified in terms of hardware queues.
> 
> The idea here is to fix hardware offloading, so schedules in hardware
> and software mode have the same behavior. What's needed to do is to
> map traffic classes to queues when applying the offload to the driver.
> 
> Fixes: 9c66d1564676 ("taprio: Add support for hardware offloading")
> Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@...el.com>

As a bug fix I've applied this to 'net' and queued it up for -stable as
well, thank you.