netdev - Re: [PATCH net] mptcp: free acked data before waiting for more memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200826.154936.1813080115853524926.davem@davemloft.net>
Date:   Wed, 26 Aug 2020 15:49:36 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     fw@...len.de
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] mptcp: free acked data before waiting for more
 memory

From: Florian Westphal <fw@...len.de>
Date: Wed, 26 Aug 2020 01:31:05 +0200

> After subflow lock is dropped, more wmem might have been made available.
> 
> This fixes a deadlock in mptcp_connect.sh 'mmap' mode: wmem is exhausted.
> But as the mptcp socket holds on to already-acked data (for retransmit)
> no wakeup will occur.
> 
> Using 'goto restart' calls mptcp_clean_una(sk) which will free pages
> that have been acked completely in the mean time.
> 
> Fixes: fb529e62d3f3 ("mptcp: break and restart in case mptcp sndbuf is full")
> Signed-off-by: Florian Westphal <fw@...len.de>

Applied and queued up for -stable, thanks.