netdev - Re: [PATCH net] ipv4: Silence suspicious RCU usage warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200826.155955.378926781937673433.davem@davemloft.net>
Date:   Wed, 26 Aug 2020 15:59:55 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     idosch@...sch.org
Cc:     netdev@...r.kernel.org, kuba@...nel.org, dsahern@...il.com,
        mlxsw@...dia.com, idosch@...dia.com
Subject: Re: [PATCH net] ipv4: Silence suspicious RCU usage warning

From: Ido Schimmel <idosch@...sch.org>
Date: Wed, 26 Aug 2020 19:48:10 +0300

> From: Ido Schimmel <idosch@...dia.com>
> 
> fib_info_notify_update() is always called with RTNL held, but not from
> an RCU read-side critical section. This leads to the following warning
> [1] when the FIB table list is traversed with
> hlist_for_each_entry_rcu(), but without a proper lockdep expression.
> 
> Since modification of the list is protected by RTNL, silence the warning
> by adding a lockdep expression which verifies RTNL is held.
 ...
> Fixes: 1bff1a0c9bbd ("ipv4: Add function to send route updates")
> Signed-off-by: Ido Schimmel <idosch@...dia.com>

Applied and queued up for -stable, thanks.