netdev - Re: [PATCH net 0/2] net: fix netpoll crash with bnxt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200826.161730.2188402243333115569.davem@davemloft.net>
Date:   Wed, 26 Aug 2020 16:17:30 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     kuba@...nel.org
Cc:     eric.dumazet@...il.com, michael.chan@...adcom.com,
        netdev@...r.kernel.org, kernel-team@...com
Subject: Re: [PATCH net 0/2] net: fix netpoll crash with bnxt

From: Jakub Kicinski <kuba@...nel.org>
Date: Wed, 26 Aug 2020 12:40:05 -0700

> Rob run into crashes when using XDP on bnxt. Upon investigation
> it turns out that during driver reconfig irq core produces
> a warning message when IRQs are requested. This triggers netpoll,
> which in turn accesses uninitialized driver state. Same crash can
> also be triggered on this platform by changing the number of rings.
> 
> Looks like we have two missing pieces here, netif_napi_add() has
> to make sure we start out with netpoll blocked. The driver also
> has to be more careful about when napi gets enabled.
> 
> Tested XDP and channel count changes, the warning message no longer
> causes a crash. Not sure if the memory barriers added in patch 1
> are necessary, but it seems we should have them.

Series applied and queued up for -stable, thanks Jakub.