netdev - Re: [PATCH v12 bpf-next 10/14] bpf: Add d

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200826092556.GA703542@krava>
Date:   Wed, 26 Aug 2020 11:25:56 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc:     Jiri Olsa <jolsa@...nel.org>, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andriin@...com>,
        KP Singh <kpsingh@...gle.com>,
        Network Development <netdev@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>, Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...omium.org>,
        Jesper Dangaard Brouer <brouer@...hat.com>
Subject: Re: [PATCH v12 bpf-next 10/14] bpf: Add d_path helper

On Tue, Aug 25, 2020 at 03:58:32PM -0700, Alexei Starovoitov wrote:
> On Tue, Aug 25, 2020 at 12:23 PM Jiri Olsa <jolsa@...nel.org> wrote:
> >  #define __BPF_FUNC_MAPPER(FN)          \
> >         FN(unspec),                     \
> > @@ -3655,7 +3668,8 @@ union bpf_attr {
> >         FN(get_task_stack),             \
> >         FN(load_hdr_opt),               \
> >         FN(store_hdr_opt),              \
> > -       FN(reserve_hdr_opt),
> > +       FN(reserve_hdr_opt),            \
> > +       FN(d_path),
> >         /* */
> 
> This is not correct. Please keep "\" at the end.
> I've missed it while applying Martin's patch.
> I've manually rebased this set due to conflict with KP's changes,
> fixed the above issue and applied.

thanks,
jirka