netdev - Re: [PATCH] mwifiex: Clean up some err and dbg messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200827095908.630E9C433A1@smtp.codeaurora.org>
Date:   Thu, 27 Aug 2020 09:59:08 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     amitkarwar@...il.com, ganapathi.bhat@....com,
        huxinming820@...il.com, davem@...emloft.net, kuba@...nel.org,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>
Subject: Re: [PATCH] mwifiex: Clean up some err and dbg messages

Christophe JAILLET <christophe.jaillet@...adoo.fr> wrote:

> The error message if 'pci_set_consistent_dma_mask()' fails is misleading.
> The function call uses 32 bits, but the error message reports 64.
> 
> Moreover, according to the comment above 'dma_set_mask_and_coherent()'
> definition, such an error can never happen.
> 
> So, simplify code, axe the misleading message and use
> 'dma_set_mask_and_coherent()' instead of 'dma_set_mask()' +
> 'dma_set_coherent_mask()'
> 
> While at it, make some clean-up:
>    - add # when reporting allocated length to be consistent between
>      functions
>    - s/consistent/coherent/
>    - s/unsigned int/u32/ to be consistent between functions
>    - align some code
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Patch applied to wireless-drivers-next.git, thanks.

5f8a3ed38bec mwifiex: Clean up some err and dbg messages

-- 
https://patchwork.kernel.org/patch/11723131/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches