lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Thu, 27 Aug 2020 10:19:03 +0000 (UTC)
From:   Kalle Valo <>
To:     Alex Dewar <>
Cc:     unlisted-recipients:; (no To-header on input)
        Alex Dewar <>,
        "David S. Miller" <>,
        Jakub Kicinski <>,,,,
Subject: Re: [PATCH] ath11k: return error if firmware request fails

Alex Dewar <> wrote:

> In ath11k_qmi_prepare_bdf_download(), ath11k_core_firmware_request() is
> called, but the returned pointer is not checked for errors. Rather the
> variable ret (which will always be zero) is checked by mistake. Fix
> this and replace the various gotos with simple returns for clarity.
> While we are at it, move the call to memset, as variable bd is not used
> on all code paths.
> Fixes: 7b57b2ddec21 ("ath11k: create a common function to request all firmware files")
> Signed-off-by: Alex Dewar <>
> Signed-off-by: Kalle Valo <>

Patch applied to ath-next branch of ath.git, thanks.

342b6194a75b ath11k: return error if firmware request fails


Powered by blists - more mailing lists