lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Thu, 27 Aug 2020 13:16:38 +0000 (UTC)
From:   Kalle Valo <>
To:     Maximilian Luz <>
Cc:     unlisted-recipients:; (no To-header on input)
        Amitkumar Karwar <>,
        Ganapathi Bhat <>,
        Xinming Hu <>,
        "David S. Miller" <>,
        Jakub Kicinski <>,
        Dan Carpenter <>,,,,
        Maximilian Luz <>,
        Kaloyan Nikolov <>
Subject: Re: [net] mwifiex: Increase AES key storage size to 256 bits

Maximilian Luz <> wrote:

> Following commit e18696786548 ("mwifiex: Prevent memory corruption
> handling keys") the mwifiex driver fails to authenticate with certain
> networks, specifically networks with 256 bit keys, and repeatedly asks
> for the password. The kernel log repeats the following lines (id and
> bssid redacted):
>     mwifiex_pcie 0000:01:00.0: info: trying to associate to '<id>' bssid <bssid>
>     mwifiex_pcie 0000:01:00.0: info: associated to bssid <bssid> successfully
>     mwifiex_pcie 0000:01:00.0: crypto keys added
>     mwifiex_pcie 0000:01:00.0: info: successfully disconnected from <bssid>: reason code 3
> Tracking down this problem lead to the overflow check introduced by the
> aforementioned commit into mwifiex_ret_802_11_key_material_v2(). This
> check fails on networks with 256 bit keys due to the current storage
> size for AES keys in struct mwifiex_aes_param being only 128 bit.
> To fix this issue, increase the storage size for AES keys to 256 bit.
> Fixes: e18696786548 ("mwifiex: Prevent memory corruption handling keys")
> Signed-off-by: Maximilian Luz <>
> Reported-by: Kaloyan Nikolov <>
> Tested-by: Kaloyan Nikolov <>
> Reviewed-by: Dan Carpenter <>
> Reviewed-by: Brian Norris <>
> Tested-by: Brian Norris <>

Patch applied to wireless-drivers.git, thanks.

4afc850e2e9e mwifiex: Increase AES key storage size to 256 bits


Powered by blists - more mailing lists