netdev - Re: [PATCH] net: exit immediately when encounter ipv6 fragment in skb_checksum_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200827.091244.2116589061763488368.davem@davemloft.net>
Date:   Thu, 27 Aug 2020 09:12:44 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     linmiaohe@...wei.com
Cc:     kuba@...nel.org, pshelar@....org, fw@...len.de,
        martin.varghese@...ia.com, edumazet@...gle.com,
        dcaratti@...hat.com, steffen.klassert@...unet.com,
        pabeni@...hat.com, shmulik@...anetworks.com,
        kyk.segfault@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: exit immediately when encounter ipv6 fragment in
 skb_checksum_setup_ipv6()

From: Miaohe Lin <linmiaohe@...wei.com>
Date: Thu, 27 Aug 2020 07:21:59 -0400

> skb_checksum_setup_ipv6() always return -EPROTO if ipv6 packet is fragment.
> So we should not continue to parse other header type in this case. Also
> remove unnecessary local variable 'fragment'.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>

Again, this optimization is arguable at best.  The code functions fine and
correctly as-is.

I'm not applying this, sorry.