lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 27 Aug 2020 17:16:26 +0000 From: "Brady, Alan" <alan.brady@...el.com> To: Jakub Kicinski <kuba@...nel.org>, "Nguyen, Anthony L" <anthony.l.nguyen@...el.com> CC: "davem@...emloft.net" <davem@...emloft.net>, "Michael, Alice" <alice.michael@...el.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "nhorman@...hat.com" <nhorman@...hat.com>, "sassmann@...hat.com" <sassmann@...hat.com>, "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>, "Burra, Phani R" <phani.r.burra@...el.com>, "Hay, Joshua A" <joshua.a.hay@...el.com>, "Chittim, Madhu" <madhu.chittim@...el.com>, "Linga, Pavan Kumar" <pavan.kumar.linga@...el.com>, "Skidmore, Donald C" <donald.c.skidmore@...el.com>, "Brandeburg, Jesse" <jesse.brandeburg@...el.com>, "Samudrala, Sridhar" <sridhar.samudrala@...el.com> Subject: RE: [net-next v5 01/15] virtchnl: Extend AVF ops > -----Original Message----- > From: Jakub Kicinski <kuba@...nel.org> > Sent: Monday, August 24, 2020 12:43 PM > To: Nguyen, Anthony L <anthony.l.nguyen@...el.com> > Cc: davem@...emloft.net; Michael, Alice <alice.michael@...el.com>; > netdev@...r.kernel.org; nhorman@...hat.com; sassmann@...hat.com; > Kirsher, Jeffrey T <jeffrey.t.kirsher@...el.com>; Brady, Alan > <alan.brady@...el.com>; Burra, Phani R <phani.r.burra@...el.com>; Hay, > Joshua A <joshua.a.hay@...el.com>; Chittim, Madhu > <madhu.chittim@...el.com>; Linga, Pavan Kumar > <pavan.kumar.linga@...el.com>; Skidmore, Donald C > <donald.c.skidmore@...el.com>; Brandeburg, Jesse > <jesse.brandeburg@...el.com>; Samudrala, Sridhar > <sridhar.samudrala@...el.com> > Subject: Re: [net-next v5 01/15] virtchnl: Extend AVF ops > > On Mon, 24 Aug 2020 10:32:52 -0700 Tony Nguyen wrote: > > +struct virtchnl_rss_hash { > > + u64 hash; > > + u16 vport_id; > > +}; > > + > > +VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_rss_hash); > > I've added 32bit builds to my local setup since v4 was posted - looks like there's > a number of errors here. You can't assume u64 forces a 64bit alignment. Best to > specify the padding explicitly. > > FWIW these are the errors I got but there may be more: > It seems like these are triggering on old messages too, curious why this wasn't caught sooner. Will fix, thanks. -Alan
Powered by blists - more mailing lists