netdev - Re: [PATCH v2 net-next 07/12] ionic: reduce contiguous memory allocation requirement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bd9b0427-6772-068e-d7bd-b1aabf1ac6ed@pensando.io>
Date:   Thu, 27 Aug 2020 12:53:17 -0700
From:   Shannon Nelson <snelson@...sando.io>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH v2 net-next 07/12] ionic: reduce contiguous memory
 allocation requirement



On 8/27/20 12:46 PM, Jakub Kicinski wrote:
> On Thu, 27 Aug 2020 11:07:30 -0700 Shannon Nelson wrote:
>> +	q_base = (void *)PTR_ALIGN((uintptr_t)new->q_base, PAGE_SIZE);
> The point of PTR_ALIGN is to make the casts unnecessary. Does it not
> work?
Here's what I see from two different compiler versions:

drivers/net/ethernet/pensando/ionic/ionic_lif.c:514:9: warning: 
assignment makes pointer from integer without a cast [-Wint-conversion]
   q_base = PTR_ALIGN((uintptr_t)new->q_base, PAGE_SIZE);


drivers/net/ethernet/pensando/ionic/ionic_lif.c:514:9: warning: 
assignment to 'void *' from 'long unsigned int' makes pointer from 
integer without a cast [-Wint-conversion]
   q_base = PTR_ALIGN((uintptr_t)new->q_base, PAGE_SIZE);

sln