netdev - Re: [PATCH bpf-next 1/5] bpf: make bpf_link_info.iter similar to bpf_iter_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzZg3D=7rkWjer49GH0_MZEf0KJH3O3tMs1gkzqMOb7t6g@mail.gmail.com>
Date:   Wed, 26 Aug 2020 21:50:47 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Yonghong Song <yhs@...com>
Cc:     bpf <bpf@...r.kernel.org>, Networking <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH bpf-next 1/5] bpf: make bpf_link_info.iter similar to bpf_iter_link_info

On Wed, Aug 26, 2020 at 5:07 PM Yonghong Song <yhs@...com> wrote:
>
> bpf_link_info.iter is used by link_query to return
> bpf_iter_link_info to user space. Fields may be different
> ,e.g., map_fd vs. map_id, so we cannot reuse
> the exact structure. But make them similar, e.g.,
>   struct bpf_link_info {
>      /* common fields */
>      union {
>         struct { ... } raw_tracepoint;
>         struct { ... } tracing;
>         ...
>         struct {
>             /* common fields for iter */
>             union {
>                 struct {
>                     __u32 map_id;
>                 } map;
>                 /* other structs for other targets */
>             };
>         };
>     };
>  };
> so the structure is extensible the same way as
> bpf_iter_link_info.
>
> Fixes: 6b0a249a301e ("bpf: Implement link_query for bpf iterators")
> Signed-off-by: Yonghong Song <yhs@...com>
> ---

I like this change, thanks!

Acked-by: Andrii Nakryiko <andriin@...com>

>  include/uapi/linux/bpf.h       | 6 ++++--
>  tools/include/uapi/linux/bpf.h | 6 ++++--
>  2 files changed, 8 insertions(+), 4 deletions(-)
>

[...]