netdev - Re: [PATCH v2 2/4] brcmfmac: drop unnecessary "fallthrough" comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9ba55d08-879b-cf66-b5d9-cc8fd292a4aa@embeddedor.com>
Date:   Thu, 27 Aug 2020 01:23:55 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Dmitry Osipenko <digetx@...il.com>,
        Arend van Spriel <arend.vanspriel@...adcom.com>,
        Franky Lin <franky.lin@...adcom.com>,
        Hante Meuleman <hante.meuleman@...adcom.com>,
        Chi-Hsien Lin <chi-hsien.lin@...ress.com>,
        Wright Feng <wright.feng@...ress.com>,
        Kalle Valo <kvalo@...eaurora.org>
Cc:     linux-wireless@...r.kernel.org,
        brcm80211-dev-list.pdl@...adcom.com,
        brcm80211-dev-list@...ress.com, netdev@...r.kernel.org,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/4] brcmfmac: drop unnecessary "fallthrough" comments

Hi,

There is a patch that address this, already:

https://lore.kernel.org/lkml/20200821063758.GA17783@embeddedor/

Thanks
--
Gustavo

On 8/27/20 01:04, Dmitry Osipenko wrote:
> There is no need to insert the "fallthrough" comment if there is nothing
> in-between of case switches. Hence let's remove the unnecessary comments
> in order to make code cleaner a tad.
> 
> Signed-off-by: Dmitry Osipenko <digetx@...il.com>
> ---
>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 2 --
>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c   | 2 --
>  2 files changed, 4 deletions(-)
> 
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
> index 1a7ab49295aa..0dc4de2fa9f6 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
> @@ -916,9 +916,7 @@ int brcmf_sdiod_probe(struct brcmf_sdio_dev *sdiodev)
>  		f2_blksz = SDIO_4373_FUNC2_BLOCKSIZE;
>  		break;
>  	case SDIO_DEVICE_ID_BROADCOM_4359:
> -		/* fallthrough */
>  	case SDIO_DEVICE_ID_BROADCOM_4354:
> -		/* fallthrough */
>  	case SDIO_DEVICE_ID_BROADCOM_4356:
>  		f2_blksz = SDIO_435X_FUNC2_BLOCKSIZE;
>  		break;
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
> index ac3ee93a2378..b16944a898f9 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
> @@ -4306,9 +4306,7 @@ static void brcmf_sdio_firmware_callback(struct device *dev, int err,
>  					   CY_43455_MESBUSYCTRL, &err);
>  			break;
>  		case SDIO_DEVICE_ID_BROADCOM_4359:
> -			/* fallthrough */
>  		case SDIO_DEVICE_ID_BROADCOM_4354:
> -			/* fallthrough */
>  		case SDIO_DEVICE_ID_BROADCOM_4356:
>  			brcmf_dbg(INFO, "set F2 watermark to 0x%x*4 bytes\n",
>  				  CY_435X_F2_WATERMARK);
>