lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Wed, 26 Aug 2020 17:09:03 -0700
From:   Shannon Nelson <snelson@...sando.io>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH net-next 11/12] ionic: change queue count with no reset

On 8/26/20 2:14 PM, Jakub Kicinski wrote:
> On Wed, 26 Aug 2020 09:42:13 -0700 Shannon Nelson wrote:
>> +	if (qparam->nxqs != lif->nxqs) {
>> +		err = netif_set_real_num_tx_queues(lif->netdev, lif->nxqs);
>> +		if (err)
>> +			goto err_out;
>> +		err = netif_set_real_num_rx_queues(lif->netdev, lif->nxqs);
>> +		if (err)
>> +			goto err_out;
> does error handling reset real_num_tx_queues to previous value?
>
>> +	}

No, the point was to not change the real_num values until we knew that 
everything else was sorted out and swapped.  However, it looks like that 
could be put right after the queues are stopped and before the swap, so 
that if the real_num change fails we can reactivate everything as it was 
and dump all the new allocations.

I'll work that up and see what it looks like.

Thanks,
sln

Powered by blists - more mailing lists