netdev - Re: [PATCH net-next] net/sched: add act_ct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM_iQpU3LLcm97xH8UUdDBQCny7UzkJ1=wf0Ssog-0YzzJ4=Zw@mail.gmail.com>
Date:   Fri, 28 Aug 2020 11:32:19 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     wenxu <wenxu@...oud.cn>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net/sched: add act_ct_output support

On Tue, Aug 25, 2020 at 1:45 AM <wenxu@...oud.cn> wrote:
>
> From: wenxu <wenxu@...oud.cn>
>
> The fragment packets do defrag in act_ct module. If the reassembled
> packet should send out to another net device. This over mtu big packet
> should be fragmented to send out. This patch add the act ct_output to
> archive this.

There are a lot of things missing in your changelog.

For example: Why do we need a new action here? Why segmentation
is not done on the target device?

At least for the egress side, dev_queue_xmit() is called by act_mirred,
it will perform a segmentation with skb_gso_segment() if needed.
So why bigger packets can not be segmented here?

Please add all these necessary details into your changelog.

Thanks.