netdev - Re: [PATCH net v2] net: dsa: mt7530: fix advertising unsupported 1000baseT_Half

Open Source and information security mailing list archives

Message-ID: <20200828105446.GK1551@shell.armlinux.org.uk>
Date:   Fri, 28 Aug 2020 11:54:46 +0100
From:   Russell King - ARM Linux admin <linux@...linux.org.uk>
To:     Landen Chao <landen.chao@...iatek.com>
Cc:     Sean Wang <sean.wang@...iatek.com>, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>, dqfext@...il.com,
        frank-w@...lic-files.de, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, opensource@...rst.com,
        linux-mediatek@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH net v2] net: dsa: mt7530: fix advertising unsupported
 1000baseT_Half

On Fri, Aug 28, 2020 at 06:52:44PM +0800, Landen Chao wrote:
> Remove 1000baseT_Half to advertise correct hardware capability in
> phylink_validate() callback function.
> 
> Fixes: 38f790a80560 ("net: dsa: mt7530: Add support for port 5")
> Signed-off-by: Landen Chao <landen.chao@...iatek.com>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

Reviewed-by: Russell King <rmk+kernel@...linux.org.uk>

Thanks.

> ---
> v1->v2
>   - fix the commit subject spilled into the commit message
> ---
>  drivers/net/dsa/mt7530.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
> index 8dcb8a49ab67..238417db26f9 100644
> --- a/drivers/net/dsa/mt7530.c
> +++ b/drivers/net/dsa/mt7530.c
> @@ -1501,7 +1501,7 @@ static void mt7530_phylink_validate(struct dsa_switch *ds, int port,
>  		phylink_set(mask, 100baseT_Full);
>  
>  		if (state->interface != PHY_INTERFACE_MODE_MII) {
> -			phylink_set(mask, 1000baseT_Half);
> +			/* This switch only supports 1G full-duplex. */
>  			phylink_set(mask, 1000baseT_Full);
>  			if (port == 5)
>  				phylink_set(mask, 1000baseX_Full);
> -- 
> 2.17.1
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives