netdev - Re: [PATCH bpf-next] bpf: make bpf_link_info.iter similar to bpf_iter_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b81b5a8b-da27-fdb4-323c-577b8d8ed5c2@iogearbox.net>
Date:   Fri, 28 Aug 2020 14:36:49 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Yonghong Song <yhs@...com>, bpf@...r.kernel.org,
        netdev@...r.kernel.org
Cc:     Alexei Starovoitov <ast@...nel.org>, kernel-team@...com,
        Andrii Nakryiko <andriin@...com>
Subject: Re: [PATCH bpf-next] bpf: make bpf_link_info.iter similar to
 bpf_iter_link_info

On 8/28/20 7:19 AM, Yonghong Song wrote:
> bpf_link_info.iter is used by link_query to return
> bpf_iter_link_info to user space. Fields may be different
> ,e.g., map_fd vs. map_id, so we cannot reuse
> the exact structure. But make them similar, e.g.,
>    struct bpf_link_info {
>       /* common fields */
>       union {
> 	struct { ... } raw_tracepoint;
> 	struct { ... } tracing;
> 	...
> 	struct {
> 	    /* common fields for iter */
> 	    union {
> 		struct {
> 		    __u32 map_id;
> 		} map;
> 		/* other structs for other targets */
> 	    };
> 	};
>      };
>   };
> so the structure is extensible the same way as
> bpf_iter_link_info.
> 
> Fixes: 6b0a249a301e ("bpf: Implement link_query for bpf iterators")
> Acked-by: Andrii Nakryiko <andriin@...com>
> Signed-off-by: Yonghong Song <yhs@...com>

Applied, thanks!