netdev - Re: [PATCH] netlink: fix a data race in netlink_rcv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 28 Aug 2020 06:51:40 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     zhudi21@...wei.com
Cc:     kuba@...nel.org, ast@...nel.org, yhs@...com,
        netdev@...r.kernel.org, rose.chen@...wei.com
Subject: Re: [PATCH] netlink: fix a data race in netlink_rcv_wake()

From: zhudi <zhudi21@...wei.com>
Date: Wed, 26 Aug 2020 20:01:13 +0800

> The data races were reported by KCSAN:
> BUG: KCSAN: data-race in netlink_recvmsg / skb_queue_tail
 ...
> Since the write is under sk_receive_queue->lock but the read
> is done as lockless. so fix it by using skb_queue_empty_lockless()
> instead of skb_queue_empty() for the read in netlink_rcv_wake()
> 
> Signed-off-by: zhudi <zhudi21@...wei.com>

Applied, thank you.