netdev - Re: [Patch net] net_sched: fix error path in red

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200828.071731.1630458922977881285.davem@davemloft.net>
Date:   Fri, 28 Aug 2020 07:17:31 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     xiyou.wangcong@...il.com
Cc:     netdev@...r.kernel.org,
        syzbot+b33c1cb0a30ebdc8a5f9@...kaller.appspotmail.com,
        syzbot+e5ea5f8a3ecfd4427a1c@...kaller.appspotmail.com,
        petrm@...lanox.com
Subject: Re: [Patch net] net_sched: fix error path in red_init()

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Thu, 27 Aug 2020 10:40:41 -0700

> When ->init() fails, ->destroy() is called to clean up.
> So it is unnecessary to clean up in red_init(), and it
> would cause some refcount underflow.
> 
> Fixes: aee9caa03fc3 ("net: sched: sch_red: Add qevents "early_drop" and "mark"")
> Reported-and-tested-by: syzbot+b33c1cb0a30ebdc8a5f9@...kaller.appspotmail.com
> Reported-and-tested-by: syzbot+e5ea5f8a3ecfd4427a1c@...kaller.appspotmail.com
> Cc: Petr Machata <petrm@...lanox.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Applied, thank you.