netdev - RE: [PATCH net-next] Add Mellanox BlueField Gigabit Ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 28 Aug 2020 14:29:10 +0000
From:   Asmaa Mnebhi <asmaa@...dia.com>
To:     Andrew Lunn <andrew@...n.ch>,
        David Thompson <dthompson@...lanox.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        Jiri Pirko <jiri@...lanox.com>,
        Asmaa Mnebhi <Asmaa@...lanox.com>
Subject: RE: [PATCH net-next] Add Mellanox BlueField Gigabit Ethernet driver

> > +static int mlxbf_gige_get_link_ksettings(struct net_device *netdev,
> > +					 struct ethtool_link_ksettings
> *link_ksettings) {
> > +	struct phy_device *phydev = netdev->phydev;
> > +	u32 supported, advertising; 
> phy_ethtool_ksettings_get() and maybe phy_ethtool_ksettings_set().

Sounds good for phy_ethtool_ksettings_get. However, there is no use for phy_ethtool_ksettings_set because our HW only supports 1G full duplex speed. (and consequently aneg is always supported).

Thanks.
Asmaa