netdev - Re: [PATCH v3 net-next 00/12] ionic memory usage rework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200828.080207.572688006909641471.davem@davemloft.net>
Date:   Fri, 28 Aug 2020 08:02:07 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     snelson@...sando.io
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH v3 net-next 00/12] ionic memory usage rework

From: Shannon Nelson <snelson@...sando.io>
Date: Thu, 27 Aug 2020 16:00:18 -0700

> Previous review comments have suggested [1],[2] that this driver
> needs to rework how queue resources are managed and reconfigured
> so that we don't do a full driver reset and to better handle
> potential allocation failures.  This patchset is intended to
> address those comments.
> 
> The first few patches clean some general issues and
> simplify some of the memory structures.  The last 4 patches
> specifically address queue parameter changes without a full
> ionic_stop()/ionic_open().
> 
> [1] https://lore.kernel.org/netdev/20200706103305.182bd727@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com/
> [2] https://lore.kernel.org/netdev/20200724.194417.2151242753657227232.davem@davemloft.net/
 ...

Series applied, thanks for doing this work as this is an area where
many drivers have poor behavior.