netdev - Re: [PATCH v2] netlabel: remove unused param from audit_log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200828.090912.720183995781297697.davem@davemloft.net>
Date:   Fri, 28 Aug 2020 09:09:12 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     alex.dewar90@...il.com
Cc:     paul@...l-moore.com, kuba@...nel.org, netdev@...r.kernel.org,
        linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] netlabel: remove unused param from
 audit_log_format()

From: Alex Dewar <alex.dewar90@...il.com>
Date: Fri, 28 Aug 2020 14:55:23 +0100

> Commit d3b990b7f327 ("netlabel: fix problems with mapping removal")
> added a check to return an error if ret_val != 0, before ret_val is
> later used in a log message. Now it will unconditionally print "...
> res=1". So just drop the check.
> 
> Addresses-Coverity: ("Dead code")
> Fixes: d3b990b7f327 ("netlabel: fix problems with mapping removal")
> Signed-off-by: Alex Dewar <alex.dewar90@...il.com>
> ---
> v2: Still print the res field, because it's useful (Paul)

Applied to net-next, thank you.