[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <29ff0728-1ef3-4c59-ad76-d6648cafe465@nvidia.com>
Date: Fri, 28 Aug 2020 20:41:08 -0700
From: Roopa Prabhu <roopa@...dia.com>
To: David Ahern <dsahern@...il.com>,
Roopa Prabhu <roopa@...ulusnetworks.com>
CC: <netdev@...r.kernel.org>, <stephen@...workplumber.org>
Subject: Re: [PATCH iproute2 net-next] iplink: add support for protodown
reason
On 8/23/20 7:20 PM, David Ahern wrote:
> External email: Use caution opening links or attachments
>
>
> On 8/20/20 9:52 PM, Roopa Prabhu wrote:
>> +void protodown_reason_n2a(int id, char *buf, int len)
>> +{
>> + if (id < 0 || id >= PROTODOWN_REASON_NUM_BITS || numeric) {
> since the reason is limited to 0-31, id > PROTODOWN_REASON_NUM_BITS
> should be an error.
copy paste from other functions in rt_names which do the same thing.
v2 coming with fix for this and other comments. thanks for the review.
Powered by blists - more mailing lists