netdev - Re: drivers/of/of_mdio.c needs a small modification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200829231632.GB2966560@lunn.ch>
Date:   Sun, 30 Aug 2020 01:16:32 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Adam Rudziński <adam.rudzinski@....net.pl>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        netdev <netdev@...r.kernel.org>, robh+dt@...nel.org,
        frowand.list@...il.com
Subject: Re: drivers/of/of_mdio.c needs a small modification

> I meant that with the split description of the mdio node the mdio bus for
> use in the system would be selected almost automatically. Suppose that I can
> do the device tree "my way":
> &fec2 {
> ...
>     mdio { phy2 ... };
> ...
> };
> &fec1 {
> ...
>     mdio { phy1 ... };
> ...
> };
> This emphasizes which PHY is intended for use by which FEC, that's why it
> looks more natural for me.

And it looks really wrong to me. It suggests there are two busses, and
each PHY is on its own bus. When in fact there is one MDIO bus with
two PHYs. Device tree should represents the real hardware, not some
pseudo description.

     Andrew