netdev - Re: [PATCH bpf-next] bpf: change bq_enqueue() return type from int to void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8eda320b-3e32-d0c2-7746-cdef52b2468e@gmail.com>
Date:   Mon, 31 Aug 2020 10:07:55 -0600
From:   David Ahern <dsahern@...il.com>
To:     Björn Töpel <bjorn.topel@...il.com>,
        ast@...nel.org, daniel@...earbox.net, bpf@...r.kernel.org
Cc:     Björn Töpel <bjorn.topel@...el.com>,
        magnus.karlsson@...el.com, netdev@...r.kernel.org, toke@...hat.com,
        brouer@...hat.com
Subject: Re: [PATCH bpf-next] bpf: change bq_enqueue() return type from int to
 void

On 8/31/20 9:07 AM, Björn Töpel wrote:
> From: Björn Töpel <bjorn.topel@...el.com>
> 
> The bq_enqueue() functions for {DEV, CPU}MAP always return
> zero. Changing the return type from int to void makes the code easier
> to follow.
> 

You can expand that to a few other calls in this code path - both
bq_flush_to_queue and bq_xmit_all always return 0 as well.