netdev - Re: [PATCH net-next 0/4] sfc: clean up some W=1 build warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200831115029.5236309c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 31 Aug 2020 11:50:29 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Edward Cree <ecree@...arflare.com>
Cc:     <linux-net-drivers@...arflare.com>, <davem@...emloft.net>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 0/4] sfc: clean up some W=1 build warnings

On Fri, 28 Aug 2020 18:48:25 +0100 Edward Cree wrote:
> A collection of minor fixes to issues flagged up by W=1.
> After this series, the only remaining warnings in the sfc driver are
>  some 'member missing in kerneldoc' warnings from ptp.c.
> Tested by building on x86_64 and running 'ethtool -p' on an EF10 NIC;
>  there was no error, but I couldn't observe the actual LED as I'm
>  working remotely.

LGTM, although borderline net if you ask me.

Reviewed-by: Jakub Kicinski <kuba@...nel.org>

> [ Incidentally, ethtool_phys_id()'s behaviour on an error return
>   looks strange — if I'm reading it right, it will break out of the
>   inner loop but not the outer one, and eventually return the rc
>   from the last run of the inner loop.  Is this intended? ]

I think you're right. Care to fix?