netdev - Re: [PATCH net-next] net: phylink: avoid oops during initialisation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 31 Aug 2020 12:23:43 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     rmk+kernel@...linux.org.uk
Cc:     andrew@...n.ch, f.fainelli@...il.com, hkallweit1@...il.com,
        netdev@...r.kernel.org, kuba@...nel.org
Subject: Re: [PATCH net-next] net: phylink: avoid oops during initialisation

From: Russell King <rmk+kernel@...linux.org.uk>
Date: Fri, 28 Aug 2020 11:53:53 +0100

> If we intend to use PCS operations, mac_pcs_get_state() will not be
> implemented, so will be NULL. If we also intend to register the PCS
> operations in mac_prepare() or mac_config(), then this leads to an
> attempt to call NULL function pointer during phylink_start(). Avoid
> this, but we must report the link is down.
> 
> Signed-off-by: Russell King <rmk+kernel@...linux.org.uk>

Applied, thank you.