netdev - Re: [PATCH 0/2 v3 net-next] 8390: core cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200831.123710.140170643696361053.davem@davemloft.net>
Date:   Mon, 31 Aug 2020 12:37:10 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     W_Armin@....de
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH 0/2 v3 net-next] 8390: core cleanups

From: David Miller <davem@...emloft.net>
Date: Mon, 31 Aug 2020 12:36:21 -0700 (PDT)

> From: Armin Wolf <W_Armin@....de>
> Date: Sat, 29 Aug 2020 13:17:32 +0200
> 
>> The purpose of this patchset is to do some
>> cleanups in lib8390.c and 8390.c.
>> 
>> While most changes are coding-style related,
>> pr_cont() usage in lib8390.c was replaced by
>> a more SMP-safe construct.
>> 
>> Other functional changes include the removal of
>> version-printing in lib8390.c so modules using lib8390.c
>> do not need a global version-string in order to compile
>> successfully.
>> 
>> Patches do compile and run flawless on 5.9.0-rc1 with
>> a RTL8029AS nic using ne2k-pci.
>  ...
> 
> Series applied to net-next.

Actually reverted, this adds a new build warning:

drivers/net/ethernet/8390/ax88796.c:58:22: warning: ‘version’ defined but not used [-Wunused-variable]
   58 | static unsigned char version[] = "ax88796.c: Copyright 2005,2007 Simtec Electronics\n";
      |                      ^~~~~~~
  C-c C-cmake[2]: *** Deleting file 'net/sunrpc/auth.o'