netdev - Re: [PATCH net-next 2/5] ionic: smaller coalesce default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200831165054.6d16f0dd@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 31 Aug 2020 16:50:54 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Shannon Nelson <snelson@...sando.io>
Cc:     netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH net-next 2/5] ionic: smaller coalesce default

On Mon, 31 Aug 2020 16:35:55 -0700 Shannon Nelson wrote:
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_dev.h b/drivers/net/ethernet/pensando/ionic/ionic_dev.h
> index 9e2ac2b8a082..2b2eb5f2a0e5 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_dev.h
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_dev.h
> @@ -16,7 +16,7 @@
>  #define IONIC_DEF_TXRX_DESC		4096
>  #define IONIC_LIFS_MAX			1024
>  #define IONIC_WATCHDOG_SECS		5
> -#define IONIC_ITR_COAL_USEC_DEFAULT	64
> +#define IONIC_ITR_COAL_USEC_DEFAULT	8

8 us interrupt coalescing does not hurt general operations?! No way.

It's your customers who'll get hurt here, so your call, but I seriously
doubt this. Unless the unit is not usec?