lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 31 Aug 2020 16:56:06 +0300 From: Kalle Valo <kvalo@...eaurora.org> To: Christian Lamparter <chunkeey@...il.com> Cc: davem@...emloft.net, kuba@...nel.org, Lee Jones <lee.jones@...aro.org>, linux-kernel@...r.kernel.org, Johannes Berg <johannes@...solutions.net>, linux-wireless@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH v2 08/30] net: wireless: ath: carl9170: Convert 'ar9170_qmap' to inline function Christian Lamparter <chunkeey@...il.com> writes: > On Thursday, 27 August 2020 11:33:51 CEST Lee Jones wrote: >> 'ar9170_qmap' is used in some source files which include carl9170.h, >> but not all of them. A 'defined but not used' warning is thrown when >> compiling the ones which do not use it. >> >> Fixes the following W=1 kernel build warning(s) >> >> from drivers/net/wireless/ath/carl9170/carl9170.h:57, >> In file included from drivers/net/wireless/ath/carl9170/carl9170.h:57, >> drivers/net/wireless/ath/carl9170/carl9170.h:71:17: warning: >> ‘ar9170_qmap’ defined but not used [-Wunused-const-variable=] >> >> NB: Snipped - lots of these repeat >> >> Cc: Christian Lamparter <chunkeey@...glemail.com> >> Cc: Kalle Valo <kvalo@...eaurora.org> >> Cc: "David S. Miller" <davem@...emloft.net> >> Cc: Jakub Kicinski <kuba@...nel.org> >> Cc: Johannes Berg <johannes@...solutions.net> >> Cc: linux-wireless@...r.kernel.org >> Cc: netdev@...r.kernel.org >> Suggested-by: Rasmus Villemoes <linux@...musvillemoes.dk> >> Signed-off-by: Lee Jones <lee.jones@...aro.org> >> --- > > For what it's worth: > Acked-by: Christian Lamparter <chunkeey@...il.com> BTW for me Acked-by tags from the maintainer are very useful. Patchwork even collects them automatically and shows the statistics so I can quickly see what patches are ready to be applied. So please do send them if you can :) -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists