netdev - Re: [PATCH net-next] net: diag: add workaround for inode truncation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200901103203.223bc13a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 1 Sep 2020 10:32:03 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, kernel-team@...com,
        zeil@...dex-team.ru, khlebnikov@...dex-team.ru, pabeni@...hat.com,
        Dave Marchevsky <davemarchevsky@...com>
Subject: Re: [PATCH net-next] net: diag: add workaround for inode truncation

On Tue, 1 Sep 2020 09:36:13 -0700 Jakub Kicinski wrote:
> On Tue, 1 Sep 2020 08:55:29 +0200 Eric Dumazet wrote:
> > On 8/31/20 4:59 PM, Jakub Kicinski wrote:  
> > > Dave reports that struct inet_diag_msg::idiag_inode is 32 bit,
> > > while inode's type is unsigned long. This leads to truncation.
> > > 
> > > Since there is nothing we can do about the size of existing
> > > fields - add a new attribute to carry 64 bit inode numbers.  
> > 
> > Last time I checked socket inode numbers were 32bit ?
> > 
> > Is there a plan changing this ?  
> 
> Ugh, you're right that appears to be a local patch :/ 
> 
> I should have checked, sorry for the noise.

Looking at get_next_ino() - it seems like the risk of overflow is very
real, no?  Should we not address this?