netdev - Re: [PATCH] can: m_can_platform: don't call m_can_class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <342496c0-4d87-3877-5d75-023c586d7076@ti.com>
Date:   Tue, 1 Sep 2020 13:20:21 -0500
From:   Dan Murphy <dmurphy@...com>
To:     Lucas Stach <l.stach@...gutronix.de>,
        Sriram Dash <sriram.dash@...sung.com>,
        Wolfgang Grandegger <wg@...ndegger.com>,
        Marc Kleine-Budde <mkl@...gutronix.de>
CC:     <linux-can@...r.kernel.org>, <netdev@...r.kernel.org>,
        Marek Vasut <marex@...x.de>, <kernel@...gutronix.de>,
        <patchwork-lst@...gutronix.de>
Subject: Re: [PATCH] can: m_can_platform: don't call m_can_class_suspend in
 runtime suspend

Lucase

On 8/11/20 3:15 AM, Lucas Stach wrote:
> 0704c5743694 (can: m_can_platform: remove unnecessary m_can_class_resume()
> call) removed the m_can_class_resume() call in the runtime resume path
> to get rid of a infinite recursion, so the runtime resume now only handles
> the device clocks. Unfortunately it did not remove the complementary
> m_can_class_suspend() call in the runtime suspend function, so those paths
> are now unbalanced, which causes the pinctrl state to get stuck on the
> "sleep" state, which breaks all CAN functionality on SoCs where this state
> is defined. Remove the m_can_class_suspend() call to fix this.
>
> Fixes: 0704c5743694 (can: m_can_platform: remove unnecessary
>                       m_can_class_resume() call)

Not sure about this wrap around for the fixes in the commit msg.

Otherwise

Acked-by: Dan Murphy <dmurphy@...com>

> Signed-off-by: Lucas Stach <l.stach@...gutronix.de>
> ---
>   drivers/net/can/m_can/m_can_platform.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/can/m_can/m_can_platform.c b/drivers/net/can/m_can/m_can_platform.c
> index 38ea5e600fb8..e6d0cb9ee02f 100644
> --- a/drivers/net/can/m_can/m_can_platform.c
> +++ b/drivers/net/can/m_can/m_can_platform.c
> @@ -144,8 +144,6 @@ static int __maybe_unused m_can_runtime_suspend(struct device *dev)
>   	struct net_device *ndev = dev_get_drvdata(dev);
>   	struct m_can_classdev *mcan_class = netdev_priv(ndev);
>   
> -	m_can_class_suspend(dev);
> -
>   	clk_disable_unprepare(mcan_class->cclk);
>   	clk_disable_unprepare(mcan_class->hclk);
>