netdev - Re: [PATCH] can: m_can: Set pinmux into "default" state on start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <341ddbb5-d46a-813a-8fe9-b0d16ca25041@denx.de>
Date:   Tue, 1 Sep 2020 20:56:08 +0200
From:   Marek Vasut <marex@...x.de>
To:     linux-can@...r.kernel.org
Cc:     Alexandre Torgue <alexandre.torgue@...com>,
        Marc Kleine-Budde <mkl@...gutronix.de>,
        Wolfgang Grandegger <wg@...ndegger.com>, dmurphy@...com,
        netdev@...r.kernel.org
Subject: Re: [PATCH] can: m_can: Set pinmux into "default" state on start

On 8/9/20 1:01 PM, Marek Vasut wrote:
> On 5/31/20 8:13 PM, Marek Vasut wrote:
>> On systems like stm32mp1 where pins have both "default" and "sleep" pinmux
>> states in DT, the pins are in "sleep" state by default. Switch the pins into
>> the "default" state when bringing the interface up in m_can_start(), because
>> otherwise no CAN communication is possible. This replicates the behavior of
>> the resume path, which does the same.
>>
>> Signed-off-by: Marek Vasut <marex@...x.de>
>> Cc: Alexandre Torgue <alexandre.torgue@...com>
>> Cc: Marc Kleine-Budde <mkl@...gutronix.de>
>> Cc: Wolfgang Grandegger <wg@...ndegger.com>
>> To: linux-can@...r.kernel.org
>> ---
>>  drivers/net/can/m_can/m_can.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
>> index 02c5795b7393..76fadf2b8ac2 100644
>> --- a/drivers/net/can/m_can/m_can.c
>> +++ b/drivers/net/can/m_can/m_can.c
>> @@ -1247,6 +1247,8 @@ static void m_can_start(struct net_device *dev)
>>  	/* basic m_can configuration */
>>  	m_can_chip_config(dev);
>>  
>> +	pinctrl_pm_select_default_state(cdev->dev);
>> +
>>  	cdev->can.state = CAN_STATE_ERROR_ACTIVE;
>>  
>>  	m_can_enable_all_interrupts(cdev);
>>
> 
> Any news on this ?

Almost another month has passed by, ping ?