netdev - Re: [net-next PATCH 1/2 v2] net: dsa: rtl8366: Check validity of passed VLANs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <59fa6313-5c9b-b1eb-9f98-1383ceb11e81@gmail.com>
Date:   Tue, 1 Sep 2020 12:11:11 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Linus Walleij <linus.walleij@...aro.org>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>
Subject: Re: [net-next PATCH 1/2 v2] net: dsa: rtl8366: Check validity of
 passed VLANs



On 9/1/2020 12:08 PM, Linus Walleij wrote:
> The rtl8366_set_vlan() and rtl8366_set_pvid() get invalid
> VLANs tossed at it, especially VLAN0, something the hardware
> and driver cannot handle. Check validity and bail out like
> we do in the other callbacks.
> 
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian