netdev - Re: [PATCH v2] net: openvswitch: pass NULL for unused parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200901.131111.186993526997490086.davem@davemloft.net>
Date:   Tue, 01 Sep 2020 13:11:11 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     trix@...hat.com
Cc:     pshelar@....org, kuba@...nel.org, natechancellor@...il.com,
        ndesaulniers@...gle.com, netdev@...r.kernel.org,
        dev@...nvswitch.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net: openvswitch: pass NULL for unused parameters

From: trix@...hat.com
Date: Sun, 30 Aug 2020 14:26:30 -0700

> Passing unused parameters is a waste.

Poorly predicted branches are an even bigger waste.

I'm not a big fan of this change and others have asked for performance
analysis to be performed.

So I'm not applying this as-is, sorry.

It's also not great to see that CLANG can't make use of the caller's
__always_unused directive to guide these warnings.