lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 1 Sep 2020 10:01:01 +0200 From: Marco Felsch <m.felsch@...gutronix.de> To: Andrew Lunn <andrew@...n.ch> Cc: davem@...emloft.net, kuba@...nel.org, robh+dt@...nel.org, f.fainelli@...il.com, hkallweit1@...il.com, linux@...linux.org.uk, zhengdejin5@...il.com, richard.leitner@...data.com, netdev@...r.kernel.org, devicetree@...r.kernel.org, kernel@...gutronix.de Subject: Re: [PATCH 5/5] net: phy: smsc: LAN8710/LAN8720: remove PHY_RST_AFTER_CLK_EN flag Hi Andrew, On 20-08-31 16:11, Andrew Lunn wrote: > On Mon, Aug 31, 2020 at 03:48:36PM +0200, Marco Felsch wrote: > > Don't reset the phy without respect to the phy-state-machine because > > this breaks the phy IRQ mode. We can archive the same behaviour if the > > refclk in is specified. > > > > Signed-off-by: Marco Felsch <m.felsch@...gutronix.de> > > --- > > drivers/net/phy/smsc.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c > > index b98a7845681f..67adf11ef958 100644 > > --- a/drivers/net/phy/smsc.c > > +++ b/drivers/net/phy/smsc.c > > @@ -337,7 +337,6 @@ static struct phy_driver smsc_phy_driver[] = { > > .name = "SMSC LAN8710/LAN8720", > > > > /* PHY_BASIC_FEATURES */ > > - .flags = PHY_RST_AFTER_CLK_EN, > > > > .probe = smsc_phy_probe, > > Hi Marco > > There are two PHYs using PHY_RST_AFTER_CLK_EN. What about the other > one? I think that they are broken too but I can't verify this therefore I left them out. Regards, Marco > > Andrew > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Powered by blists - more mailing lists