netdev - Re: [PATCH 01/32] wireless: marvell: mwifiex: sdio: Move 'static const struct's into their own header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200901091541.3974FC433C6@smtp.codeaurora.org>
Date:   Tue,  1 Sep 2020 09:15:41 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     davem@...emloft.net, kuba@...nel.org, linux-kernel@...r.kernel.org,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        Lee Jones <lee.jones@...aro.org>,
        Amitkumar Karwar <amitkarwar@...il.com>,
        Ganapathi Bhat <ganapathi.bhat@....com>,
        Xinming Hu <huxinming820@...il.com>
Subject: Re: [PATCH 01/32] wireless: marvell: mwifiex: sdio: Move 'static
 const
 struct's into their own header file

Lee Jones <lee.jones@...aro.org> wrote:

> Only include these tables in the 1 source file they are used.
> 
> Fixes hundreds of W=1 warnings!
> 
> Fixes the following W=1 kernel build warning(s):
> 
>  In file included from drivers/net/wireless/marvell/mwifiex/main.h:59,
>  from drivers/net/wireless/marvell/mwifiex/main.c:22:
>  drivers/net/wireless/marvell/mwifiex/sdio.h:705:41: warning: ‘mwifiex_sdio_sd8801’ defined but not used [-Wunused-const-variable=]
>  705 | static const struct mwifiex_sdio_device mwifiex_sdio_sd8801 = {
>  | ^~~~~~~~~~~~~~~~~~~
> 
>  NB: There were 100's of these - snipped for brevity.
> 
> Cc: Amitkumar Karwar <amitkarwar@...il.com>
> Cc: Ganapathi Bhat <ganapathi.bhat@....com>
> Cc: Xinming Hu <huxinming820@...il.com>
> Cc: Kalle Valo <kvalo@...eaurora.org>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: linux-wireless@...r.kernel.org
> Cc: netdev@...r.kernel.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>

I don't think static const variables should be in a .h file. Wouldn't
sdio.c be the right place for these? At least from a quick look I got
that impression.

Patch set to Changes Requested.

-- 
https://patchwork.kernel.org/patch/11728301/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches