lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 1 Sep 2020 07:14:35 -0400 From: "Michael S. Tsirkin" <mst@...hat.com> To: Yunsheng Lin <linyunsheng@...wei.com> Cc: jasowang@...hat.com, kvm@...r.kernel.org, virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, linuxarm@...wei.com Subject: Re: [PATCH net-next] vhost: fix typo in error message On Tue, Sep 01, 2020 at 10:39:09AM +0800, Yunsheng Lin wrote: > "enable" should be "disable" when the function name is > vhost_disable_notify(), which does the disabling work. > > Signed-off-by: Yunsheng Lin <linyunsheng@...wei.com> Acked-by: Michael S. Tsirkin <mst@...hat.com> Why net-next though? It's a bugfix, can go into net. > --- > drivers/vhost/vhost.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c > index 5857d4e..b45519c 100644 > --- a/drivers/vhost/vhost.c > +++ b/drivers/vhost/vhost.c > @@ -2537,7 +2537,7 @@ void vhost_disable_notify(struct vhost_dev *dev, struct vhost_virtqueue *vq) > if (!vhost_has_feature(vq, VIRTIO_RING_F_EVENT_IDX)) { > r = vhost_update_used_flags(vq); > if (r) > - vq_err(vq, "Failed to enable notification at %p: %d\n", > + vq_err(vq, "Failed to disable notification at %p: %d\n", > &vq->used->flags, r); > } > } > -- > 2.8.1
Powered by blists - more mailing lists