netdev - Re: [PATCH net-next] selftests: mptcp: fix typo in mptcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <022366c7-c916-8841-348b-b1981341b810@tessares.net>
Date:   Wed, 2 Sep 2020 15:32:30 +0200
From:   Matthieu Baerts <matthieu.baerts@...sares.net>
To:     Davide Caratti <dcaratti@...hat.com>
Cc:     mptcp@...ts.01.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] selftests: mptcp: fix typo in mptcp_connect
 usage

Hi Davide,

On 02/09/2020 13:44, Davide Caratti wrote:
> in mptcp_connect, 's' selects IPPROTO_MPTCP / IPPROTO_TCP as the value of
> 'protocol' in socket(), and 'm' switches between different send / receive
> modes. Fix die_usage(): swap 'm' and 's' and add missing 'sendfile' mode.

Good catch!

I guess we don't need this on -net or further, this test program is 
always used with its wrapper mptcp_connect.sh.

Reviewed-by: Matthieu Baerts <matthieu.baerts@...sares.net>

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net