netdev - Re: [PATCH bpf-next] xsk: fix possible segfault in xsk umem diagnostics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <06ad8200-8b81-fbaf-b796-d0961b83e170@iogearbox.net>
Date:   Wed, 2 Sep 2020 16:57:49 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Magnus Karlsson <magnus.karlsson@...el.com>, bjorn.topel@...el.com,
        ast@...nel.org, netdev@...r.kernel.org, jonathan.lemon@...il.com
Cc:     bpf@...r.kernel.org
Subject: Re: [PATCH bpf-next] xsk: fix possible segfault in xsk umem
 diagnostics

On 9/2/20 10:52 AM, Magnus Karlsson wrote:
> Fix possible segfault in the xsk diagnostics code when dumping
> information about the umem. This can happen when a umem has been
> created, but the socket has not been bound yet. In this case, the xsk
> buffer pool does not exist yet and we cannot dump the information
> that was moved from the umem to the buffer pool. Fix this by testing
> for the existence of the buffer pool and if not there, do not dump any
> of that information.
> 
> Signed-off-by: Magnus Karlsson <magnus.karlsson@...el.com>
> Reported-by: syzbot+3f04d36b7336f7868066@...kaller.appspotmail.com
> Fixes: c2d3d6a47462 ("xsk: Move queue_id, dev and need_wakeup to buffer pool")
> Fixes: 7361f9c3d719 ("xsk: Move fill and completion rings to buffer pool")

Applied, thanks!