netdev - Re: [PATCH iproute2 net-next v2] iplink: add support for protodown reason

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bbb1ce0c-c5e5-bdfd-57e4-80e6ccf6d3b3@gmail.com>
Date:   Tue, 1 Sep 2020 19:54:53 -0600
From:   David Ahern <dsahern@...il.com>
To:     Roopa Prabhu <roopa@...ulusnetworks.com>, dsahern@...il.com
Cc:     netdev@...r.kernel.org, stephen@...workplumber.org
Subject: Re: [PATCH iproute2 net-next v2] iplink: add support for protodown
 reason

On 8/28/20 9:42 PM, Roopa Prabhu wrote:
> From: Roopa Prabhu <roopa@...ulusnetworks.com>
> 
> This patch adds support for recently
> added link IFLA_PROTO_DOWN_REASON attribute.
> IFLA_PROTO_DOWN_REASON enumerates reasons
> for the already existing IFLA_PROTO_DOWN link
> attribute.
> 
> $ cat /etc/iproute2/protodown_reasons.d/r.conf
> 0 mlag
> 1 evpn
> 2 vrrp
> 3 psecurity
> 

none of these are standardized right? Or perhaps they are through FRR?

Would be worth mentioning in the man page that the reasons are localized
if so.

> 
> Note: for somereason the json and non-json key for protodown
> are different (protodown and proto_down). I have kept the
> same for protodown reason for consistency (protodown_reason and
> proto_down_reason).
> 
> Signed-off-by: Roopa Prabhu <roopa@...ulusnetworks.com>
> ---
> v2 - address comments from David Ahern
> 

applied to iproute2-next. Thanks