netdev - Re: [PATCH] net: bcmgenet: fix mask check in bcmgenet_validate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <74100a9f-5215-ed55-7077-a180a85f775a@gmail.com>
Date:   Wed, 2 Sep 2020 10:53:51 -0700
From:   Doug Berger <opendmb@...il.com>
To:     Denis Efremov <efremov@...ux.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        bcm-kernel-feedback-list@...adcom.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] net: bcmgenet: fix mask check in bcmgenet_validate_flow()

On 9/2/2020 4:18 AM, Denis Efremov wrote:
> VALIDATE_MASK(eth_mask->h_source) is checked twice in a row in
> bcmgenet_validate_flow(). Add VALIDATE_MASK(eth_mask->h_dest)
> instead.
> 
> Fixes: 3e370952287c ("net: bcmgenet: add support for ethtool rxnfc flows")
> Cc: stable@...r.kernel.org
> Signed-off-by: Denis Efremov <efremov@...ux.com>
> ---
> I'm not sure that h_dest check is required here, it's only my guess.
> Compile tested only.
> 
>  drivers/net/ethernet/broadcom/genet/bcmgenet.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> index 0ca8436d2e9d..be85dad2e3bc 100644
> --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> @@ -1364,7 +1364,7 @@ static int bcmgenet_validate_flow(struct net_device *dev,
>  	case ETHER_FLOW:
>  		eth_mask = &cmd->fs.m_u.ether_spec;
>  		/* don't allow mask which isn't valid */
> -		if (VALIDATE_MASK(eth_mask->h_source) ||
> +		if (VALIDATE_MASK(eth_mask->h_dest) ||
>  		    VALIDATE_MASK(eth_mask->h_source) ||
>  		    VALIDATE_MASK(eth_mask->h_proto)) {
>  			netdev_err(dev, "rxnfc: Unsupported mask\n");
> 
Well spotted. Thanks!

Acked-by: Doug Berger <opendmb@...il.com>